Odoo Web Client

Merge lp:~openerp-dev/openobject-client-web/6.0-opw-583890-cpa into lp:openobject-client-web

6.0-opw-583890-cpa
Merge into 6.0

Proposed by Chirag Patel (OpenERP) on 2013-01-09

Status:	Needs review
Proposed branch:	lp:~openerp-dev/openobject-client-web/6.0-opw-583890-cpa
Merge into:	lp:openobject-client-web
Diff against target:	42 lines (+6/-1) 3 files modified addons/openerp/controllers/form.py (+2/-1) addons/openerp/static/javascript/form.js (+1/-0) addons/openerp/static/javascript/m2m.js (+3/-0)
To merge this branch:	bzr merge lp:~openerp-dev/openobject-client-web/6.0-opw-583890-cpa
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Xavier ALT (community)		2013-01-09	Needs Fixing on 2013-01-11
Review via email: mp+142447@code.launchpad.net

Description of the change

Hello,

m2m not support readonly attrs.

Steps:
1) Customize the users form view by adding the following attrs on groups_id field: {'readonly':[('name','=','test')]}
2) Create new user.
3) Enter name "test".

Observed: Groups box is slightly greyed out, but add button still not readonly.
Expected: The add button on the groups box should not be clickable.

Thanks

Revision history for this message

Xavier ALT (dex-phx) wrote on 2013-01-11:

Hi,

Commit is fine, but doesn't fix all use-cases:

Case 1:
=======
1a. Do steps 1), 2), 3) => button "Add" is disabled (so this is ok)
2a. Then clic on the column header "Name"

Observed: many2many widget is reloaded - but attrs seems to not be re-applied => widget still grey-out, but button is re-enabled.
Expected: both widget and button should be inactive.

Case 2:
=======
1a. Do steps 1), 2), 3) => button "Add" is disabled (so this is ok)
2a. Then try to remove one of the proposed default group (ex: Employee) from the many2many by clicking the cross "x"

Observed: item is really removed from the many2many
Expected: as readonly, we should not be able to remove item from the list.

Regards,
Xavier

review: Needs Fixing

lp:~openerp-dev/openobject-client-web/6.0-opw-583890-cpa updated on 2013-04-03

4900. By Launchpad Translations on behalf of openerp on 2013-01-27: Launchpad automatic translations update.
4901. By Launchpad Translations on behalf of openerp on 2013-01-31: Launchpad automatic translations update.
4902. By Launchpad Translations on behalf of openerp on 2013-02-02: Launchpad automatic translations update.
4903. By Xavier ALT on 2013-02-05: [FIX] OPW 581748: user password change wizard should not use 'super-admin' terminology from database op.
4904. By Launchpad Translations on behalf of openerp on 2013-02-06: Launchpad automatic translations update.
4905. By Launchpad Translations on behalf of openerp on 2013-02-08: Launchpad automatic translations update.
4906. By Launchpad Translations on behalf of openerp on 2013-02-09: Launchpad automatic translations update.
4907. By Xavier ALT on 2013-03-01: [FIX] web: fixup api for correct field validators init
4908. By Launchpad Translations on behalf of openerp on 2013-03-09: Launchpad automatic translations update.
4909. By Xavier ALT on 2013-03-10: [FIX] OPW 17626: corresponding fix for single-quote in button confirm message of r4705, but for list view
4910. By Launchpad Translations on behalf of openerp on 2013-03-18: Launchpad automatic translations update.
4911. By Chris Biersbach (OpenERP) on 2013-03-25: [MERGE] OPW 582169: Changes the timeout for pinting reports from a hardcoded value to the openerp server timeout config value
4912. By Launchpad Translations on behalf of openerp on 2013-04-02: Launchpad automatic translations update.
4913. By Chirag Patel (OpenERP) on 2013-04-03: [FIX] Remove edit,add and delete button in readonly m2m.

Unmerged revisions

4913. By Chirag Patel (OpenERP) on 2013-04-03: [FIX] Remove edit,add and delete button in readonly m2m.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Ariel E. Figueroa - http://www.humanytek.com

Arif

Bhumi Thakkar (Open ERP)

Carlos Contreras

Christophe CHAUVET

Dharmesh PATEL@Axelor SARL

Jiten (OpenERP)

Juano

Krisztian Eyssen

Mandip Dave

Michael Lu

Navrang Oza

Nitesh Vaghani

OpenERP Core Team

OpenERP R&D Team

Philippe Préaux

Sananaz (Open ERP)

Vaibhav Darji

kifcaliph

to status/vote changes:

Gustavo Earnshaw

              search_data=None, filter_domain=None, o2m_edit=False, **kw):
         notebook_tab = kw.get('notebook_tab') or 0
+        editable = kw.get('editable', True);
         params = self._read_form(context, count, domain, filter_domain, id,
                                  ids, kw, limit, model, offset, search_data,
                                  search_domain, source, view_ids, view_mode,
-                                 view_type, notebook_tab, o2m_edit=o2m_edit, editable=True)
+                                 view_type, notebook_tab, o2m_edit=o2m_edit, editable=editable)
         if not params.ids:
             params.count = 0
         'offset': openobject.dom.get(prefix + '_terp_offset').value,
         'limit': openobject.dom.get(prefix + '_terp_limit').value,
         'count': openobject.dom.get(prefix + '_terp_count').value,
+        'editable': openobject.dom.get(prefix + '_terp_editable').value,
         'search_domain': jQuery('#_terp_search_domain').val() || null,
         'search_data': jQuery('#_terp_search_data').val() || null,
         'filter_domain': jQuery('#_terp_filter_domain').val() || [],
         $field.add(this.text)
                 .attr('readOnly', readonly)
                 .toggleClass('readonlyfield', readonly);
+       var bool = readonly ? 'False' : 'True';
+       jQuery(idSelector(this.name+'/_terp_editable')).val(bool);
+       ListView(this.name).reload();
     },
     addRecords: function () {