Merge lp:~mvo/software-center/per-thread-xapiandb into lp:software-center
Proposed by
Michael Vogt
Status: | Merged |
---|---|
Merged at revision: | 2331 |
Proposed branch: | lp:~mvo/software-center/per-thread-xapiandb |
Merge into: | lp:software-center |
Diff against target: |
155 lines (+64/-41) 2 files modified
softwarecenter/db/database.py (+56/-33) softwarecenter/db/enquire.py (+8/-8) |
To merge this branch: | bzr merge lp:~mvo/software-center/per-thread-xapiandb |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Lasker (community) | Approve | ||
Michael Vogt | Pending | ||
Review via email: mp+75349@code.launchpad.net |
Description of the change
Hopefully kills off race condition behind #736116 (and maybe even #638706)
To post a comment you must log in.
Hey mvo! This is a nice and very clever approach, and it certainly does appear to have have excellent potential for taking care of those bugs you mention (and as you know the second of the two, the DocNotFound master bug, is our current most evil one of all).
I did a bunch of testing and this does appear to maintain a unique database instance per each thread, exactly as intended. I could not detect a case where a given thread_name was changed to use a different database.
So, this one seems good to me! If this takes care of the DocNotFound errors, man, that will call for a serious celebration!