Merge lp:~mvo/software-center/lp977179 into lp:software-center
Status: | Merged |
---|---|
Merged at revision: | 2977 |
Proposed branch: | lp:~mvo/software-center/lp977179 |
Merge into: | lp:software-center |
Diff against target: |
74 lines (+8/-15) 1 file modified
softwarecenter/ui/gtk3/widgets/reviews.py (+8/-15) |
To merge this branch: | bzr merge lp:~mvo/software-center/lp977179 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Lasker (community) | Approve | ||
Review via email: mp+101926@code.launchpad.net |
Description of the change
This branch started out to fix the crash in bug #977179 (it still does fix that).
But then I got carried away a bit and fixed the fact that the reviews UI does not react
properly to network change events currently. The problem is that we use "show_all" after _fill()
which means that when the elements are hidden they become visible again. This branch should fix
that now.
To test open a package with reviews like eg. apt and disconnect network-manager. In trunk
you will still see "was this review useful yes/no" but with that branch those elementes are
hidden now. Same when starting without network. When the network becomes available the elements
become available as well.
Extra critical review for this is appreciated :)
Michael, this is really nice. It does just the right thing. Thanks!