Notify OSD

Merge lp:~macslow/notify-osd/fix-559109 into lp:notify-osd/lucid

  1. fix-559109
  2. Merge into lucid
Proposed by Mirco Müller
Status: Merged
Merged at revision: not available
Proposed branch: lp:~macslow/notify-osd/fix-559109
Merge into: lp:notify-osd/lucid
Diff against target: 23 lines (+8/-2)
1 file modified
src/bubble.c (+8/-2)
To merge this branch: bzr merge lp:~macslow/notify-osd/fix-559109
Reviewer Review Type Date Requested Status
Cody Russell (community) Approve
Review via email: mp+23378@code.launchpad.net

Description of the change

Use an empty region for the non-composite fade instead of gtk_widget_show() and gtk_widget_hide(), fixes LP: #559109

To post a comment you must log in.
Revision history for this message
Cody Russell (bratsche) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/bubble.c'
--- src/bubble.c 2010-04-07 13:40:24 +0000
+++ src/bubble.c 2010-04-14 10:07:16 +0000
@@ -1632,11 +1632,17 @@
1632 // we're not-composited, so deal with mouse-over differently1632 // we're not-composited, so deal with mouse-over differently
1633 if (bubble_is_mouse_over (self))1633 if (bubble_is_mouse_over (self))
1634 {1634 {
1635 gtk_widget_hide (priv->widget);1635 GdkRegion* region = NULL;
1636
1637 region = gdk_region_new ();
1638 gdk_window_shape_combine_region (priv->widget->window,
1639 region,
1640 0,
1641 0);
1642 gdk_region_destroy (region);
1636 }1643 }
1637 else1644 else
1638 {1645 {
1639 gtk_widget_show (priv->widget);
1640 gtk_widget_get_size_request (priv->widget, &width, &height);1646 gtk_widget_get_size_request (priv->widget, &width, &height);
1641 mask = (GdkBitmap*) gdk_pixmap_new (NULL, width, height, 1);1647 mask = (GdkBitmap*) gdk_pixmap_new (NULL, width, height, 1);
1642 if (mask)1648 if (mask)

Subscribers

People subscribed via source and target branches

to all changes: