Ubuntu Software Center

Merge lp:~kiwinote/software-center/properly-rendered-banners into lp:software-center

  1. properly-rendered-banners
  2. Merge into trunk
Proposed by Kiwinote
Status: Merged
Merged at revision: 2781
Proposed branch: lp:~kiwinote/software-center/properly-rendered-banners
Merge into: lp:software-center
Diff against target: 29 lines (+10/-1)
2 files modified
debian/changelog (+9/-0)
softwarecenter/ui/gtk3/widgets/exhibits.py (+1/-1)
To merge this branch: bzr merge lp:~kiwinote/software-center/properly-rendered-banners
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Review via email: mp+94800@code.launchpad.net

Description of the change

this should solve the issue with the first banner being an empty banner and having to wait for the banner transition timeout before we get a properly rendered banner

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks! That looks good, but I wonder why webkit changed here :/ Oh well :) Thanks a lot for the fix, I'm sure this was not easy to debug.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-02-23 16:41:24 +0000
+++ debian/changelog 2012-02-27 16:59:27 +0000
@@ -1,3 +1,12 @@
1software-center (5.1.11) UNRELEASED; urgency=low
2
3 * softwarecenter/ui/gtk3/widgets/exhibits.py:
4 - increase delay between the 'load-finished' signal from webkit and us
5 actually trying to get a pixbuf of the surface - this means that the
6 initial banner is actually rendered properly rather than plain white
7
8 -- Kiwinote <kiwinote@gmail.com> Mon, 27 Feb 2012 16:49:48 +0000
9
1software-center (5.1.10) precise; urgency=low10software-center (5.1.10) precise; urgency=low
211
3 [ Michael Vogt ]12 [ Michael Vogt ]
413
=== modified file 'softwarecenter/ui/gtk3/widgets/exhibits.py'
--- softwarecenter/ui/gtk3/widgets/exhibits.py 2011-11-16 10:53:13 +0000
+++ softwarecenter/ui/gtk3/widgets/exhibits.py 2012-02-27 16:59:27 +0000
@@ -126,7 +126,7 @@
126 if view.get_property("load-status") == WebKit.LoadStatus.FINISHED:126 if view.get_property("load-status") == WebKit.LoadStatus.FINISHED:
127 # this needs to run with a timeout because otherwise the 127 # this needs to run with a timeout because otherwise the
128 # status is emited before the offscreen image is finihsed128 # status is emited before the offscreen image is finihsed
129 GObject.timeout_add(1, lambda: self.emit("render-finished"))129 GObject.timeout_add(100, lambda: self.emit("render-finished"))
130130
131 def on_download_error(self, loader, exception, error):131 def on_download_error(self, loader, exception, error):
132 LOG.warn("download failed: '%s', '%s'" % (exception, error))132 LOG.warn("download failed: '%s', '%s'" % (exception, error))

Subscribers

People subscribed via source and target branches