Zorba

  1. Bug #989490
  2. Comment #5

Comment 5 for bug 989490

Revision history for this message
David Graf (davidagraf) wrote :

Hey Chris

>> (Also - what was the reason you changed JAVA_AWT_INCLUDE_DIRECTORIES to JAVA_AWT_INCLUDE_PATH? That doesn't seem to make sense.)

That's a typo. Thanks for telling me.

2) I don't like these changes, although I'm not sure of the alternative. IMHO the existing FindJNI code with all of its many specific hard-coded paths is bogus, and your change just extends the bogusness. There Must Be A Better Way(tm).
>> We should tell our fixes to the cmake guys.

>> At any rate, no, I do not believe that this should be in Zorba 2.5 because it's too late, and because I'm unwilling to toss in a hack at the last minute that I'm not sure I agree with. Also, it appears that the work-around for anyone who runs into trouble is easy: Set JAVA_HOME in your environment before running CMake.

True.