Comment 1 for bug 98490

Revision history for this message
Philipp von Weitershausen (philikon) wrote :

I'm a bit skeptical because we now make engines take another keyword argument in their translate() method. Not sure if this is a good idea, it might break backward-compatibility.

Either way, this patch should come with an accompanying test that demonstrates i18n:target now actually works. "I've tested it myself" isn't enough because the rest of can't repeat it. Furthermore, we can't repeat it in an automated fashion. That's why we require unit tests.

There are plenty of existing tests that you can probably just enhance with one for i18n:target.