Comment 3 for bug 98333

Revision history for this message
Björn Tillenius (bjornt) wrote :

Well, I wouldn't reject this bug based on your comment. What you're saying is that a lot of widgets, like ChoiceInputWidger, RadioWidget, use _getFormValue() even though they shouldn't, which is basically the same bug. Although I can't see how you came to that conclusion. The docstring you quoted says that widgets that can't represent their value in a single HTML form value shouldn't use that method. But a Choice and radio widget can do that, they map an object to a single token, which means that it should be able to use _getFormValue().

However, I'm not sure that this bug is worth fixing, due to the complexity of the problem. If you fix it, you have to change the (currently broken) semantics of some methods, which means that you might break other people widgets, since they might depend on the broken semantics. It's probably easier to create a new set of core widgets than to fix the existing ones.