Sidnei da Silva wrote:
>> - The original commits in r92767 shows no signs of unit tests being
>> written. Why was this?
>
> I believe if you revert r92767 there are tests in Five that break, so
> it was a fix for a newer version of Five that got integrated later.
As long as there are *some* tests that fail, that'd be better than
nothing...
Can you confirm which tests fail when you revert r92767?
>> - Zope 2 no longer support Python 2.4, so I'm not sure we need to
>> special cases for Python 2.4
>
> We don't need to intentionally break it either *wink*.
I don't think it's an intentional break, but ugly ahcks just to support
2.4 have little point as the Zope2 egg as a whole won't run under
Python2.4 anymore...
Sidnei da Silva wrote:
>> - The original commits in r92767 shows no signs of unit tests being
>> written. Why was this?
>
> I believe if you revert r92767 there are tests in Five that break, so
> it was a fix for a newer version of Five that got integrated later.
As long as there are *some* tests that fail, that'd be better than
nothing...
Can you confirm which tests fail when you revert r92767?
>> - Zope 2 no longer support Python 2.4, so I'm not sure we need to
>> special cases for Python 2.4
>
> We don't need to intentionally break it either *wink*.
I don't think it's an intentional break, but ugly ahcks just to support
2.4 have little point as the Zope2 egg as a whole won't run under
Python2.4 anymore...
Chris
-- www.simplistix. co.uk
Simplistix - Content Management, Zope & Python Consulting
- http://