Comment 5 for bug 880207

Revision history for this message
Jonathan Ballet (multani) wrote : [Bug 880207] Re: Report skipped tests

On Tue, Oct 25, 2011 at 05:19:34PM -0000, Tres Seaver wrote:
> The attached patch makes the formatter API backward-compatible:
> omitting the 'n_skipped' argument causes the "old" format to be emitted.
>
> Because isn't going to be straigtforward to test this across versions
> which do / don't support the 'skipped' feature in 'unittest2', we
> should bump the version number (i.e., to '4.1'), and ensure that the ZTK
> 1.0 and 1.1 configurations continue to use a branch created from before
> this patch is merged. We can then update the tests to match the new
> format (including the 'skipped' output).

To be clear: we keep the formatter API backward-compatible even if we
bump the version, ditch the old format (without the 'skipped' output)
along with the few branches in the code to support both and we only test
the new format?

> ** Patch added: "lp_880207-alternate.patch"
> https://bugs.launchpad.net/zope.testrunner/+bug/880207/+attachment/2572027/+files/lp_880207-alternate.patch

I looked at the patch, and there were two issues to fix:

* there were 2 calls to output.summary() in runner.py;
* there were 2 superfluous self.color('info') in the summary() method of
  the colored formatter, and a couple of extra whitespace too.

I attach the fixed version to this message.