On Tue, Oct 25, 2011 at 03:44:33PM -0000, Tres Seaver wrote:
> I'm looking at the patch now. Could we make the formatter API backward-
> compatible by putting the 'n_skipped' argument last, and defaulting it to
> 'None'? I realize that it makes the API read somewhat awkwardly, but I
> think that having things "Just Work" under older Python versions, or where
> 'unittest2' is not present, trumps that. We could then keep the output text
> compatible if 'n_skipped' was not passed (those same cases).
I'm not sure to perfectly understand what you mean but just to be clear:
* you can still run zope.testrunner with an older version of Python
(without the new unittest module) or without unittest2. So, things
should "Just Work" with those setups;
* but it breaks the internal zope.testrunner API: people who
had a custom output formatter will need to adjust their code;
* it also breaks things if you were relying on the text output.
I had the feeling you were implying that it wasn't working 'normally'
with 'non-compatible' versions, but if you agree if the points above, so
everything is fine.
On Tue, Oct 25, 2011 at 03:44:33PM -0000, Tres Seaver wrote:
> I'm looking at the patch now. Could we make the formatter API backward-
> compatible by putting the 'n_skipped' argument last, and defaulting it to
> 'None'? I realize that it makes the API read somewhat awkwardly, but I
> think that having things "Just Work" under older Python versions, or where
> 'unittest2' is not present, trumps that. We could then keep the output text
> compatible if 'n_skipped' was not passed (those same cases).
I'm not sure to perfectly understand what you mean but just to be clear:
* you can still run zope.testrunner with an older version of Python
(without the new unittest module) or without unittest2. So, things
should "Just Work" with those setups;
* but it breaks the internal zope.testrunner API: people who
had a custom output formatter will need to adjust their code;
* it also breaks things if you were relying on the text output.
I had the feeling you were implying that it wasn't working 'normally'
with 'non-compatible' versions, but if you agree if the points above, so
everything is fine.