This patch looks sane to me, but I don't know the innards of zope.sendmail very well. A couple of points in its favor:
- All tests continue to pass with the patch applied.
- The change to the discriminator makes it match what the handler actually does at execution time.
One downside: the patch does not add a test which demonstrates the failure case.
This patch looks sane to me, but I don't know the innards of zope.sendmail very well. A couple of points in its favor:
- All tests continue to pass with the patch applied.
- The change to the discriminator makes it match what the handler actually does at execution time.
One downside: the patch does not add a test which demonstrates the failure case.