On Wed, Oct 20, 2010 at 7:03 AM, Danny Navarro <email address hidden> wrote:
> For windows I guess I could handle the AttributeError exception that
> would be raised zrpc.client.ConnectionManager._guess_type when
> socket.AF_UNIX is not found. I could also raise the exception upfront
> earlier if windows is detected. I don't know what happens in windows
> when trying to use a unix domain address, I don't have a windows
> installation at hand.
I wasn't expecting you to make a windows error sane in this case.
That would be nice, but a bonus. :) If you do this, then
we'd need a windows test, which would be hard for you to
debug.
> I also saw that in order to test the unix sockets properly I would have
> to do some changes start_zeo_server in ZEO/tests/forker.py to support
> addresses of unix sockets.
If you use forker. I'm not sure that's necessary.
You could probably just instantiate a StorageServer
instance in a thread.
> Alternatively I could monkey patch the address of an already created TCP
> server ZEO server in ZEO/tests/client-config.test to look like a unix
> domain socket. But I don't know if that kind of test would be really
> useful.
I don't really follow this.
> Let me know what would you like to do about that and I will give it a
> try.
It would probably be easier (for both of us) for me to fix this. :)
If you want to get involved in ZEO development
and want a learning opportunity, I'm happy work with you.
On Wed, Oct 20, 2010 at 7:03 AM, Danny Navarro <email address hidden> wrote: ConnectionManag er._guess_ type when
> For windows I guess I could handle the AttributeError exception that
> would be raised zrpc.client.
> socket.AF_UNIX is not found. I could also raise the exception upfront
> earlier if windows is detected. I don't know what happens in windows
> when trying to use a unix domain address, I don't have a windows
> installation at hand.
I wasn't expecting you to make a windows error sane in this case.
That would be nice, but a bonus. :) If you do this, then
we'd need a windows test, which would be hard for you to
debug.
> I also saw that in order to test the unix sockets properly I would have
> to do some changes start_zeo_server in ZEO/tests/forker.py to support
> addresses of unix sockets.
If you use forker. I'm not sure that's necessary.
You could probably just instantiate a StorageServer
instance in a thread.
> Alternatively I could monkey patch the address of an already created TCP client- config. test to look like a unix
> server ZEO server in ZEO/tests/
> domain socket. But I don't know if that kind of test would be really
> useful.
I don't really follow this.
> Let me know what would you like to do about that and I will give it a
> try.
It would probably be easier (for both of us) for me to fix this. :)
If you want to get involved in ZEO development
and want a learning opportunity, I'm happy work with you.
Let me know.
Jim
--
Jim Fulton