Comment 5 for bug 663259

Revision history for this message
Danny Navarro (jdnavarro) wrote :

For windows I guess I could handle the AttributeError exception that would be raised zrpc.client.ConnectionManager._guess_type when socket.AF_UNIX is not found. I could also raise the exception upfront earlier if windows is detected. I don't know what happens in windows when trying to use a unix domain address, I don't have a windows installation at hand.

I also saw that in order to test the unix sockets properly I would have to do some changes start_zeo_server in ZEO/tests/forker.py to support addresses of unix sockets.

Alternatively I could monkey patch the address of an already created TCP server ZEO server in ZEO/tests/client-config.test to look like a unix domain socket. But I don't know if that kind of test would be really useful.

Let me know what would you like to do about that and I will give it a try.