Enable ZEO log rotation

Bug #143600 reported by Mark Hammond
10
Affects Status Importance Assigned to Milestone
ZODB
Fix Released
Medium
Unassigned

Bug Description

Currently ZEO ignores SIGUSR2 signals, which was in the past used for log rotation (Zope still does use that signal).

I'm attaching a patch that should give ZEO the same log rotation capabilities as Zope. Sadly I'm not in a position to test linux, but it *should* work <wink>. It works for Windows. Only tested under a ZEO that runs next to a Zope (ie, not in stand-alone ZODB, whatever that means :)

Revision history for this message
Mark Hammond (mhammond) wrote :
Revision history for this message
Sidnei da Silva (sidnei) wrote :

FWIW, I've just tested the patch on linux and it works great with a ZEO instance created by './bin/mkzeoinstance.py' from a Zope 2.8 checkout.

affects: zope2 → zodb
Revision history for this message
Hanno Schlichting (hannosch) wrote :

In 143786 it's also noted that "zeoctl logreopen" doesn't do anything.

Changed in zodb:
assignee: nobody → Hanno Schlichting (hannosch)
status: New → Confirmed
Revision history for this message
Jim Fulton (jim-zope) wrote :

http://svn.zope.org/?rev=116788&view=rev

Thanks for the patch. I wrote a test for Unix. See
runzeo_logrotate_on_sigusr2 in ZEO.tests.testZEO.

It would be great if someone wrote a test for windows or updated the
test to work on windows.

How does one even send a signal on windows? (And, if we can't, then
why register a signal handler?)

Changed in zodb:
status: Confirmed → Fix Committed
Changed in zodb:
assignee: Hanno Schlichting (hannosch) → nobody
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers