Comment 16 for bug 142667

On Oct 10, 2008, at 10:53 AM, Tres Seaver wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Jim Fulton wrote:
>> On Oct 10, 2008, at 8:26 AM, Tres Seaver wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Artur Zaprzała wrote:
>>>> As for your patch, looking at ZODB 3.8 I didn't find a possibility
>>>> for
>>>> self._reader to not exist or be None. Did I miss something?
>>> I think you are correct for the 3.8 branch: it alloacates the
>>> '_reader'
>>> in '__init__'. I was applying the fix to older versions, as well,
>>> where the '_reader' object is not created until the end of '_setDB',
>>> *after* the call to ''_resetCache'.
>>
>>
>> Does this mean the patch isn't needed for 3.8? It sounds like the
>> test
>> would still be useful.
>
> No, it means that the test for a non-existent '_reader' can be dropped
> (I have done that in my 3,8 sandbox).

OK, well, whenever you're ready, go ahead and commit.

I assume that this is isolated enough that we don't need another 3.8.1
beta. I will review the diff after you commit to reassure myself that
this is true. :)

Jim

--
Jim Fulton
Zope Corporation