Comment 29 for bug 542994

El Lunes 05 Julio 2010, Jaap Karssenberg escribió:
> Manual synced svn branch to bzr (see lp:~pardus-cpan/zim/pyzim-maemo)
> and did some cleanups (see changes in revision 230 and 231)
You removed the accelerator key combination for hiding/showing the toolbar
(<ctrl>M). Actually that's not an option for maemo5 and the N900 device, so I
wrapped it with a "if" sentence (see attached patch).
Everything else is fine.
> 3 remaining questions:
>
> 1) Should we force dialogs on maemo to always use 800x480 ? This would
> reduce the maemo specific code per dialog. Or does it make sense to have
> specific dialogs on a different size ?
Big or complex dialogs, yes. Some, like the calendar dialog, no, they would
look ugly. We can decide on this later, when I have adapted more dialogs.
> 2) The following comment in pageview.py is internally contradicting:
>
> """
> Maemo hildon input method keyboard doesn't emit keypress events except for
> TAB, ENTER and BACKSPACE so we provide TAB as an alternative END_OF_WORD
> key that works with the current keypress event driven implementation """
>
> If no keypress event is generated for TAB adding to current keypress
> handler will also not work - so probably something else is going on here
The key word there is "except"
Let me say it in other words: Maemo hildon input method keyboard (aka stylus
keyboard) emits keypress events only for TAB, ENTER and BACKSPACE

> 3) What is the function of the tap_and_hold_setup() call for the
> fullscreen toolbar item - why do we need a object property "fsbutton"
> that is not used anywhere else?
It is a function to attach a menu to a widget, that will be brought by
simulating a right click by keeping the finger/stylus pressing on the widget
for a while.
I used the fsbutton property to be able to reference the fullscreen widget
later, if needed.

--
Don't see the world through a window, be open{source}minded, and be free :-)