Comment 4 for bug 495392
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I think it looks good. The primary missing point is documentation. The DBus API needs to be documented in this regard. This also holds for the recent change with event id 0 indicates an error.
It's ok to merge without it. If you don't get around to this it's ok - I'll try to remember doing it before the release if not.