Comment 8 for bug 121325

I had not seen r97510.

r97510 takes another baby step toward the work I put together last October. It converts one call of os.popen4 to subprocess.Popen.

There are still several calls within easy_install that call subprocesses. All of these use if/else and handle the results somewhat differently depending on if jython is present or not. Also, windows arguments are handled in an ad-hoc manner, requiring every instance of an argument to be properly wrapped by the _safe_arg call.

My patch eliminates the need for the _safe_arg function, although it's kept for compatibility in case other dependent projects use it. It also factors the jython-specific code into its own module for clear designation. This eliminates a lot of duplicate code and makes the module somewhat easier to read. There are fewer branches and more unified handling.

I've merged the patch once again against the trunk. I hope this new revision will be considered for inclusion.