Upstart support for Zabbix services

[Christian Kampka]

Ubuntu uses Upstart instead of SysVInit to run the init process.
Attached debdiff includes upstart scripts that will allow Upstart to
start/stop all zabbix daemon components. Installation of the scripts
will happen automatically using Ubuntus Upstart debhelper scripts,
Debian will simply ignore them.

The patch was also sent upstream to the Debian maintainers.

[James Hunt (jamesodhunt)]

These Upstart job configuration files look very good. Just a couple of points:

- are the following files required? Do they apply where no default database has been configured? Or are they an oversight?

  zabbix-proxy-.upstart
  zabbix-server-.upstart

- Since all the .upstart files share the same pre-start, as an optimisation, you could potentially create a "zabbix-setup" job that does that setup and have it 'start on (filesystem and net-device up IFACE=lo)' and 'export DIR' such that the remaining Upstart jobs could simply 'start on started zabbix-setup'.

[Christian Kampka (kampka)]

Those files are indeed unnecessary because the debdiff (of course) swallowed the symlinks.
Originally the upstart scripts for different components are just symlinks to these generic ones since they are really all the same and just exist for debhelper magic.
Since debian rejected the debdiff anyways I have created a bzr branch that can handle the symlinks.

I'll take a look at the setup job as soon as I find the time.

[Christian Kampka (kampka)]

I feel like using symlinks for the upstart files already resolved most of what you could remedy by having an additional zabbix-setup job. As things are now, it would mean pulling one line from the generic upstart file and creating a new job just for creating a runtime directory. There is no benefit for administrators either because the services files are renamed to a generic version when building the package so there is ever only one upstart file present when deployed.
To me, adding the additional job feels more like adding additional complexity rather than optimization.

If you feel passionate about this, I would be okay with adding the additional setup job, but I can see little benefit in doing so.

[James Hunt (jamesodhunt)]

Christian - sym links are not supported. See init(5) and http://upstart.ubuntu.com/cookbook/#symbolic-links-don-t-work-in-etc-init.

[Christian Kampka (kampka)]

Am 02.10.2012 16:31, schrieb James Hunt:
> Christian - sym links are not supported. See init(5) and
> http://upstart.ubuntu.com/cookbook/#symbolic-links-don-t-work-in-etc-
> init.
>

James, symlinks are used to keep the code synchronous since all
respective upstart script are identical. They are then resolved during
build (hence the additional files in the debdiff) so all files installed
to /etc/init are off course actual files. No symlinks are ever being
installed to /etc/init.
Hope this explains it more clearly.

[James Page (james-page)]

Christian

I think that the upstart configurations look good; however I'm reticent to push a change in the way that zabbix is started to quantal so late in the development cycle.

LGTM and should be uploaded as soon as R opens...

[Dimitri John Ledkov (xnox)]

Next time, merge proposals are made, please add "(LP: 1047837)" in the changelog, such that the bug is automatically closed on upload.

[Michael Chernyak (michael-chernyak)]

upstart for zabbix-agent is broken.
see https://bugs.launchpad.net/ubuntu/+source/zabbix/+bug/1103720

there is a fix in zabbix main line, but I guess it's easier to go back to SysVInit then to port the fix