Comment 154 for bug 681904

Revision history for this message
nik.martin (nik-martin) wrote :

This driver is broken on official kernel 3.8. In linux/drivers/input/mouse/input-mt.c:
function input_mt_init_slots now requires 3 args, with the new arg being flags. I set flags to 0 in synaptics.c:699 in this patch and it re-compiled fine. I have no clue as to what that will break, but I saw in the mainline kernel synaptics.c that's what it was set to.

/**
 * input_mt_init_slots() - initialize MT input slots
 * @dev: input device supporting MT events and finger tracking
 * @num_slots: number of slots used by the device
 * @flags: mt tasks to handle in core
 *
 * This function allocates all necessary memory for MT slot handling
 * in the input device, prepares the ABS_MT_SLOT and
 * ABS_MT_TRACKING_ID events for use and sets up appropriate buffers.
 * Depending on the flags set, it also performs pointer emulation and
 * frame synchronization.
 *
 * May be called repeatedly. Returns -EINVAL if attempting to
 * reinitialize with a different number of slots.
 */
int input_mt_init_slots(struct input_dev *dev, unsigned int num_slots,
                        unsigned int flags)