Comment 13 for bug 1349838

Revision history for this message
Siergiej Riaguzow (riaguzov) wrote :

Arhur, it's a pity launchpad doesn't seem to allow to edit comments.

Anyway, looking through the code, XpadTextView and XpadTextBuffer have parents GtkSourceView and GtkSourceBuffer respectively and they use casts inside of them and they do have some code so Sagar seems to made his job just fine.

It's just that he has left the names misleading. IMHO what should've been done is just renaming:

XpatTextView - XpadSourceView
XpadTextBuffer - XpadSourceBuffer
(instead of removing them alltogether since they do have some code inside)

As removing XpadUndo (which I ask you to put accept and merge) appeared to be easy and everything worked (by using undo/redo of GtkSourceBuffer) I think that implementing search (the bug that is preventing myself from using xpad) should be relatively easy too.

I've just removed XpadUndo now. I can create a patch for this change instead of pointing to a commit in a branch if this is easier for you. If you will accept it I can then implement search since this seems to be major.

And after search is accepted I can then created a separate branch for renaming the "classes" and cleanups (as per clang, and migrating guides) since these are minor. If you will confirm xpad should be buildable with GTK2 I will do that while making my changes to ensure everything is working.