Xfce4 Desktop

Bug #77702
Comment #55

Comment 55 for bug 77702

Revision history for this message

In Xfce Bugzilla #3812, Brian Tarricone (kelnos) wrote on 2008-05-29:

#55

(In reply to comment #28)
> Created an attachment (id=1648) [details]
> Yet another valgrind log

Similar to my last comment... loss record 1950 looks like it's probably my fault, but the crucial bits of the stack trace are missing. Not sure why :-( .

I don't understand loss record 3979. The GLists returned by thunarx are definitely all freed (see xfdesktop_file_icon_manager_real_init() and _fini()). Ah, I see. That's actually inside thunarx_provider_factory_load_modules() -- thunarx does a bit of caching; I doubt that's a real leak (and if it is, it's a thunar bug).

Loss record 5195 is a one-time allocation that never gets freed by design.

5349 and 5378 are like 1950 -- need more info.

Not sure about 5566, but seems similar to 5195.

5876, 5887, 5941, 5967, 6013, 6051 are probably my fault, suffer from the same problem as 1950, and are additionally probably very difficult to find, even with the full stack trace.

5944, 5957, 5971, 5976, 5979, 5980, 5982, 5983, 6048 are very puzzling. There was only one instance in the menu module where gtk_container_get_children() was missing a corresponding g_list_free(), which was fixed in svn rev 26635. I'm not sure what to make of this, and the blank parts in the stack trace are a big problem. There's a lot of mem supposedly lost here, so it's likely this is a problem.

5958 is another 1950 -- missing crucial stacktrace info.

5977, 5999, 6018 looks like lots of menu items aren't getting destroyed -- or it could just be that the cached menu widget isn't getting destroyed when the app quits. I'd assume the latter, cuz I can't see how we'd be losing track of menu items like that. But this is probably worth looking into.

6004, 6021 are more 1950s.

Any I didn't mention are just non-leaks in libc/freetype/pango/gtk/etc.

I'm really confused by the broken stack traces. The "??"s in many of those cases should be inside xfdesktop or in the menu module. Is it possible the menu module's debuginfo isn't working properly? Or... something else? Also it might be helpful to try an unoptimised build -- I see a few areas there where some functions on the stack are missing (probably inlined), and it's a little annoying to read that way.

(In reply to comment #28)
> Created an attachment (id=1648) [details]
> Yet another valgrind log

Similar to my last comment... loss record 1950 looks like it's probably my fault, but the crucial bits of the stack trace are missing.  Not sure why :-( .

I don't understand loss record 3979.  The GLists returned by thunarx are definitely all freed (see xfdesktop_file_icon_manager_real_init() and _fini()).  Ah, I see.  That's actually inside thunarx_provider_factory_load_modules() -- thunarx does a bit of caching; I doubt that's a real leak (and if it is, it's a thunar bug).

Loss record 5195 is a one-time allocation that never gets freed by design.

5349 and 5378 are like 1950 -- need more info.

Not sure about 5566, but seems similar to 5195.

5876, 5887, 5941, 5967, 6013, 6051 are probably my fault, suffer from the same problem as 1950, and are additionally probably very difficult to find, even with the full stack trace.

5944, 5957, 5971, 5976, 5979, 5980, 5982, 5983, 6048 are very puzzling.  There was only one instance in the menu module where gtk_container_get_children() was missing a corresponding g_list_free(), which was fixed in svn rev 26635.  I'm not sure what to make of this, and the blank parts in the stack trace are a big problem.  There's a lot of mem supposedly lost here, so it's likely this is a problem.

5958 is another 1950 -- missing crucial stacktrace info.

5977, 5999, 6018 looks like lots of menu items aren't getting destroyed -- or it could just be that the cached menu widget isn't getting destroyed when the app quits.  I'd assume the latter, cuz I can't see how we'd be losing track of menu items like that.  But this is probably worth looking into.

6004, 6021 are more 1950s.

Any I didn't mention are just non-leaks in libc/freetype/pango/gtk/etc.

I'm really confused by the broken stack traces.  The "??"s in many of those cases should be inside xfdesktop or in the menu module.  Is it possible the menu module's debuginfo isn't working properly?  Or... something else?  Also it might be helpful to try an unoptimised build -- I see a few areas there where some functions on the stack are missing (probably inlined), and it's a little annoying to read that way.