Comment 136 for bug 1335492

Revision history for this message
In , Ap-z (ap-z) wrote :

Created attachment 6763
Patch for xfdesktop-file-icon-manager.c in version 4.12.3 to read icon positions from open file.

The attached patch adds three methods to replace calls to
xfdesktop_file_icon_manager_get_cached_icon_position().

Before, the file icons.screen-???.rc with the saved icon positions was opened, read and closed for each icon separately. If anything triggered a rewrite of the file, while the icon positions were still read individually, some icon positions were lost.

With my patch the file is only opened once and kept around until all icons have their position set.

This also fixes the bug for me, and it's a better solution too.

@ Gerold Schellstede:

Could you try this patch? Maybe this solves it for you, too...