Comment 17 for bug 428575

Revision history for this message
AJenbo (ajenbo) wrote :

I hope you localiced all the lang strings before you committed that fix.

My contry is Denmark

iCountry 45
sCountry Danmark

Also have you tested this on a English edition of Windows set to a different country? If I set my standard formats to Netherlands, sCountry = Holland (the Danish word for Netherlands), so now you just broke Wubi for any one with a version of windows that doesn't match the set number scheme and or keyboard layout.
Why the heck are you checking the sCountry instead of iCountry?

Not to mention, sCountry and iCountry has nothing to do with the keyboard layout, it indicates how numbers and dates should be formatted.

A girl i know uses a German laptop, it has a German keyboard layout, but she runs a English version of Windows with local settings set to Danish.
Here sCountry there for would be "Denmark". Before your fix her computer would be seen as having a Danish keyboard, with your fix it will probably end up as Italian, but none of them are correct!

I'm off to see if i can find a proper fix for this mess, in the mean time I suggest you withdraw your fix and make Wubi use iCountry instead of sCountry, it can be that hard to get the mapping from MSDN some where.