Immovable attribs (e.g. stone) are not translatable
Bug #999262 reported by
Dirk Stöcker
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I proposed a branch for merging, which fixes some I18n bugs.
Revision 6383 is uncritical,
http://
Revision 6384 is more a guess how the issues should be fixed.
http://
Please consider either merging the branch or copying the fixes to the code in any other form.
https:/
Related branches
lp:~widelands-dev/widelands/bug-999262
- SirVer: Pending requested
-
Diff: 33 lines (+5/-9)1 file modifiedsrc/logic/worker.cc (+5/-9)
lp:~widelands-dev/widelands/bug-999262_part2
- SirVer: Approve
-
Diff: 1406 lines (+307/-102)79 files modifiedsrc/ai/defaultai.cc (+2/-2)
src/logic/militarysite.cc (+3/-3)
src/logic/militarysite.h (+1/-1)
src/logic/production_program.cc (+6/-7)
src/logic/production_program.h (+1/-1)
src/logic/productionsite.cc (+41/-1)
src/logic/productionsite.h (+22/-0)
src/logic/worker.cc (+8/-50)
src/logic/worker.h (+0/-4)
tribes/atlanteans/blackroot_farm/conf (+5/-0)
tribes/atlanteans/coalmine/conf (+4/-0)
tribes/atlanteans/crystalmine/conf (+4/-0)
tribes/atlanteans/farm/conf (+5/-0)
tribes/atlanteans/fishers_house/conf (+4/-0)
tribes/atlanteans/goldmine/conf (+4/-0)
tribes/atlanteans/hunters_house/conf (+6/-0)
tribes/atlanteans/ironmine/conf (+4/-0)
tribes/atlanteans/quarry/conf (+6/-2)
tribes/atlanteans/stonecutter/conf (+1/-1)
tribes/atlanteans/well/conf (+5/-0)
tribes/atlanteans/woodcutters_house/conf (+5/-0)
tribes/barbarians/coalmine/conf (+4/-0)
tribes/barbarians/deep_coalmine/conf (+4/-0)
tribes/barbarians/deep_goldmine/conf (+4/-0)
tribes/barbarians/deep_oremine/conf (+4/-0)
tribes/barbarians/deeper_coalmine/conf (+4/-0)
tribes/barbarians/deeper_goldmine/conf (+4/-0)
tribes/barbarians/deeper_oremine/conf (+4/-0)
tribes/barbarians/farm/conf (+5/-0)
tribes/barbarians/fishers_hut/conf (+4/-0)
tribes/barbarians/goldmine/conf (+4/-0)
tribes/barbarians/granitemine/conf (+4/-0)
tribes/barbarians/hunters_hut/conf (+6/-0)
tribes/barbarians/lumberjacks_hut/conf (+5/-0)
tribes/barbarians/oremine/conf (+4/-0)
tribes/barbarians/quarry/conf (+5/-1)
tribes/barbarians/reed_yard/conf (+5/-0)
tribes/barbarians/stonemason/conf (+1/-1)
tribes/barbarians/well/conf (+5/-0)
tribes/empire/coalmine/conf (+4/-0)
tribes/empire/deep_coalmine/conf (+4/-0)
tribes/empire/deep_goldmine/conf (+4/-0)
tribes/empire/deep_marblemine/conf (+4/-0)
tribes/empire/deep_oremine/conf (+4/-0)
tribes/empire/farm/conf (+5/-0)
tribes/empire/fishers_house/conf (+4/-0)
tribes/empire/goldmine/conf (+4/-0)
tribes/empire/hunters_house/conf (+6/-0)
tribes/empire/lumberjacks_house/conf (+5/-0)
tribes/empire/marblemine/conf (+4/-0)
tribes/empire/oremine/conf (+4/-0)
tribes/empire/quarry/conf (+6/-2)
tribes/empire/stonemason/conf (+2/-2)
tribes/empire/vineyard/conf (+5/-0)
tribes/empire/well/conf (+5/-0)
world/immovables/stones/blackland_stones1/init.lua (+1/-1)
world/immovables/stones/blackland_stones2/init.lua (+1/-1)
world/immovables/stones/blackland_stones3/init.lua (+1/-1)
world/immovables/stones/blackland_stones4/init.lua (+1/-1)
world/immovables/stones/blackland_stones5/init.lua (+1/-1)
world/immovables/stones/blackland_stones6/init.lua (+1/-1)
world/immovables/stones/desert_stones1/init.lua (+1/-1)
world/immovables/stones/desert_stones2/init.lua (+1/-1)
world/immovables/stones/desert_stones3/init.lua (+1/-1)
world/immovables/stones/desert_stones4/init.lua (+1/-1)
world/immovables/stones/desert_stones5/init.lua (+1/-1)
world/immovables/stones/desert_stones6/init.lua (+1/-1)
world/immovables/stones/greenland_stones1/init.lua (+1/-1)
world/immovables/stones/greenland_stones2/init.lua (+1/-1)
world/immovables/stones/greenland_stones3/init.lua (+1/-1)
world/immovables/stones/greenland_stones4/init.lua (+1/-1)
world/immovables/stones/greenland_stones5/init.lua (+1/-1)
world/immovables/stones/greenland_stones6/init.lua (+1/-1)
world/immovables/stones/winterland_stones1/init.lua (+1/-1)
world/immovables/stones/winterland_stones2/init.lua (+1/-1)
world/immovables/stones/winterland_stones3/init.lua (+1/-1)
world/immovables/stones/winterland_stones4/init.lua (+1/-1)
world/immovables/stones/winterland_stones5/init.lua (+1/-1)
world/immovables/stones/winterland_stones6/init.lua (+1/-1)
Changed in widelands: | |
status: | Confirmed → Fix Committed |
status: | Fix Committed → Confirmed |
Changed in widelands: | |
milestone: | build18-rc1 → build19-rc1 |
tags: | added: internationalization |
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | Confirmed → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
Changed in widelands: | |
status: | Incomplete → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
> Revision 6384 is more a guess how the issues should be fixed. bazaar. launchpad. net/~stoecker/ widelands/ fixes/revision/ 6384
> http://
Did you compile and test whether it works?
res_type is an attribute of an object and thus not translateable - you are still right that this should be fixed, but a correct fix would be to define a translateable name for each attribute globally and to use it in the message.
f.immovable.name is the name of the directory of the building and thus not translateable as well. Again you are right, that it should be fixed, but the right fix would be to implement a lua function that returns the descriptive name and at best already translated.
I am not sure about your changes in rev 6383, as I am not that deep into lua. Were those lines untranslated without those changes?
Please do not get me wrong - it is very good, that you start to tackle this bugs. it's just that it is not yet ready to be merged, as it does not have the intended behaviour.