Comment 2 for bug 988498

Ok, I've looked back into this.

It is fairly easy to get the cppcheck working again in WL_EXTRAWARNINGS by changing to --enable=all rather than the currently assigned values.

That said, it is very noisy since it prints each issue each time it finds it for all files and it is slightly hard to separate compiler warnings from cppcheck issues in the output. (My approach for creating the warning logs has been to print everything written to stderr to a file). I think only a tiny minority ever looks at this, and given the noise level it is hardly of any use, so I doubt anyone would miss it.

utils/create_cppcheck_report on the other hand provides a rather nice report with each issue on less than 300 lines at the moment, which is a lot easier to relate to and look into. I therefore agree we should drop this and focus on the report script. Note that I have made some improvements to it, and I'll submit a patch shortly.

Oh, and Jens; regarding the false positive which we have been suppressing; it shows up with cppcheck 1.49, but I no longer get it when checking the file with version 1.54 so I assume they have fixed it.