We celebrate the recent release of cppcheck 1.61 by running it on r6698 to see what it has to say.
Looks like mostly the same things as last time, though a few comments:
- There's one issue about BOOST_FOREACH
- "src/network/nethost.cc:2237] -> [src/network/network_protocol.h:49: (style) Variable 'CLIENT_TIMESTAMP_INTERVAL' hides enumerator with same name" sounds potentially pretty bad, though I haven't looked closely at it.
- I recently saw someone create a branch which added threading to parts of WL. Cppcheck lists a lot of function calls which can be replaced by their threadsafe version, so if we are pushing towards threading we probably need to take a look at that.
We celebrate the recent release of cppcheck 1.61 by running it on r6698 to see what it has to say.
Looks like mostly the same things as last time, though a few comments: nethost. cc:2237] -> [src/network/ network_ protocol. h:49: (style) Variable 'CLIENT_ TIMESTAMP_ INTERVAL' hides enumerator with same name" sounds potentially pretty bad, though I haven't looked closely at it.
- There's one issue about BOOST_FOREACH
- "src/network/
- I recently saw someone create a branch which added threading to parts of WL. Cppcheck lists a lot of function calls which can be replaced by their threadsafe version, so if we are pushing towards threading we probably need to take a look at that.