Workarea color policy

Bug #898129 reported by Angelo Locritani on 2011-11-30
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Low
cghislai

Bug Description

question started in http://wl.widelands.org/forum/topic/928/

Fortress controls up to 11 "distance-units" away
Citadel controls up to 12 "distance-units" away

But first 11 "distance-units" of a fortress are orange-marked, and only the last one (the one that you'll control when you upgrade to citadel) is normally marked.
I think it should be the opposite: mark first 11 points with normal mark and the remaining 1 with a orange mark (and not a orange border)
or
mark first 11 points with normal mark + orange border and the last one with orange mark (not border) only

this way the normal (blue) marked area is alway the current active area, while at the moment for military buildings it's the future (extended) working area.

Tags: ui Edit Tag help

Related branches

SirVer (sirver) wrote :

Could you provide screenshots of the current state and your suggestion? it would make the discussion easier.

SirVer (sirver) on 2011-12-02
Changed in widelands:
status: New → Incomplete
Angelo Locritani (alocritani) wrote :

I attach a screenshot showing current situation and 3 proposal. Please consider that the proposals are simple mokeups, no change done in code.

SirVer (sirver) wrote :

I am for #3 - the graphics could be improved though - the rings are hard to see.

Hans Joachim Desserud (hjd) wrote :

Here's an alternative proposal. The idea is to signal the parts covered by an enhanched building is marked with a green plus. The same plus could also be used in the building window along with the building it is enhanched to. It's a bit off-topic, but I find the current solution of showing the building it would be enhanced into a bit lacking. With the green plus introduced it would be recognizable as tied to enhancing buildings, so that it would be easy to figure out the meaning.

I am also fond of #3 above, expect I think the colors should be improved. I also think this is a better representation than the current, which would help players form a correct mental model. The following reasoning would be a lot clearer:
* The filled circle is the base area
* The ring around is the enchanched area which would be added to the initial one to make a larger circle.
In fact, this is the reverse of what the current solution indicates.

Changed in widelands:
importance: Undecided → Low
tags: added: ui
Hans Joachim Desserud (hjd) wrote :

expect should be except in the second paragraph...

I like your hjd's suggestion but I have one problem: what about
buildings that can be enhanced twice. The pluses can't be easily
doubled. I therefore still prefer #3. Also, the pluses in your image are
subtle and hard to miss.

It set this bug to triaged now but please do not take this as a sign to
stop discussing it. It only means that one valid solution is already
found - a better one will even be better.

  status triaged

Changed in widelands:
status: Incomplete → Triaged
Hans Joachim Desserud (hjd) wrote :

>Also, the pluses in your image are subtle and hard to miss.
Well, mine were only to illustrate the idea. Naturally, someone would have to actually draw some proper, goodlooking pluses.

>what about buildings that can be enhanced twice.

Yes, I forgot all about them. What is the strategy here for #3, btw? Circle/ring1/ring2, then both rings, then only outer ring (going from closest to furthest away)?

SirVer (sirver) wrote :

>Yes, I forgot all about them. What is the strategy here for #3, btw?
>Circle/ring1/ring2, then both rings, then only outer ring (going from
>closest to furthest away)?
Sounds reasonable to me.

Hans Joachim Desserud (hjd) wrote :

I just discovered duplicate bug 536473, which suggests adding a semitransparent circle around the building. This seems like a good idea to me, but I am not sure how feasible this is currently. The bug report contains more details, as well as links to what is considered requirements. I am not sure if this is still lacking or if it is in place, so it would be nice if someone in the know could take a look at it. For instance it talks about waiting for opengl, which was added a long time ago.

SirVer (sirver) wrote :

well, OpenGL rendering will land in build 17 as default rendering. That
is, the basics for rendering semitransparent circles or what not quickly
is then in place. The main question is if we want to keep compatibility
with software rendering then. However, this is to be decided after b17
is out of the door.

Changed in widelands:
assignee: nobody → cghislai (charlyghislain)
Changed in widelands:
status: Triaged → In Progress
cghislai (charlyghislain) wrote :

the fix commited is the proposal #3 from comment #2.
I suggest we discuss the semitransparent opengl thing in bug 536473

Changed in widelands:
status: In Progress → Fix Committed
milestone: none → build18-rc1
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers