Hello Rob and welcome to the Widelands bug tracker!
Yes, when upgrading or destroying a building all wares will be lost. This has been discussed a bit before in bug 559854 and bug 587251. I believe any further discussion or anything you wish to add should happen in the other bug reports. (I am marking this as a duplicate of bug 559854. (Unfortunately the discussion is a bit spread between the two bugs mentioned earlier and one more, but they all cover different aspects, so I don't think it would be right to mark all of them duplicate in order to cut it down to a single report.)
Feel free to report any other bugs you may find in the future.
Hello Rob and welcome to the Widelands bug tracker!
Yes, when upgrading or destroying a building all wares will be lost. This has been discussed a bit before in bug 559854 and bug 587251. I believe any further discussion or anything you wish to add should happen in the other bug reports. (I am marking this as a duplicate of bug 559854. (Unfortunately the discussion is a bit spread between the two bugs mentioned earlier and one more, but they all cover different aspects, so I don't think it would be right to mark all of them duplicate in order to cut it down to a single report.)
Feel free to report any other bugs you may find in the future.