Comment 8 for bug 726139

Revision history for this message
SirVer (sirver) wrote :

I actually have a Observer/Observable class in one of my dangling branches (The one working on the editor), so I agree that it is kinda useful to have.

Your branch renamed build/ which I guess was not intentional. I reverted this before merging. I am also not terribly happy with having the signal being mutable inside the WaresList. It means for one that we can only have one Ui element watching any WaresList and secondly having mutable members is usually not such a good idea and has code smell.

I can see why you wanted to implement the Observer/Observable pattern here. If you feel like it, go ahead. But for now the patch is okay as it stands. Thanks for your work!!