Frisian bushes not localized

Bug #1805155 reported by Benedikt Straub
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

The names of the frisian berry bushes are shown in English in the in-game encyclopedia.

Related branches

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I can confirm this.
Helptexts for the ressources aren't localized either.
The strings are in transifex though.

Changed in widelands:
status: New → Confirmed
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

have to correct myself
Bushes strings are in transifex.
setting textdomain to "tribes" in

..\data\tribes\immovables\berry_bushes\blueberry will fix this.

Other thing for the resi helptexts. Couldn't find them on transifex.

Changed in widelands:
milestone: none → build20-rc1
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

ok resi helptexts filenames differ from standard filenames recognized by buildcat.py needs to be updated.
If we do so there will be around 10 longer strings to be translated,
If we won't do so we should remove the helptexts from the res indicators.

Revision history for this message
kaputtnik (franku) wrote :

Can you take care of this?

I think we should have the helptexts for the resi translated.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I think GunChleoc should take care of the buildcat.py part as she is usually doing the build catalog and fetch translations task. I really don't want to mess around with this.

the other one (berry bushes) is simple and can be done easily in the same step.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

+1 for having the resi texts in b20 from my side

Revision history for this message
GunChleoc (gunchleoc) wrote :

+1 from me too. We still have desyncs to debug, which will give translators enough time to catch up.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

ok so if you like to update the buildcat.py script you need to ensure it catches all *.lua files in the following directory:

data/tribes/immovables/resi/helptexts.

This will add the resi descriptions to localized strings.

for the Frisian bushes we need to add

Set textdomian ("tribes") to the blueberry decription

Revision history for this message
kaputtnik (franku) wrote :

The attached branch should take care of buildcat.py. At least running it will show the helptexts for resources localized. The branch does not contain the po-files which get changed when running the script. (i have removed them with 'bzr revert po/*')

For the frisian bushes i am not sure if setting the textdomain is the correct approach. All other files like that uses pgettext for this, e.g.:

  -- TRANSLATORS: This is an immovable name used in lists of immovables
   descname = pgettext("immovable", "Blackroot Field (ripe)"),

hessenfarmer, can you adjust the branch to get the berry bushes translated?

Revision history for this message
GunChleoc (gunchleoc) wrote :

pgettext has nothing to do with the textdomain - it's there for disambiguation in case the same word appears multiple times as a source string. This allows us to have both "Krieger" and "Soldat" for "Soldier" etc.

The change to buildcat.py looks good.

Revision history for this message
kaputtnik (franku) wrote :

> hessenfarmer, can you adjust the branch to get the berry bushes translated?

friendly ping?

kaputtnik (franku)
Changed in widelands:
assignee: nobody → kaputtnik (franku)
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Hi kapputnik,

Sorry my time is limited currently, and as I was not subscribed to this bug I overlooked your ping.

From my point of view the branch looks good so far. I will review and approve it then

Revision history for this message
kaputtnik (franku) wrote :

No problem :-)

Thanks for the review and the merge!

kaputtnik (franku)
Changed in widelands:
status: Confirmed → Fix Committed
assignee: kaputtnik (franku) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers