Comment 5 for bug 1786613

Revision history for this message
Toni Förster (stonerl) wrote :

I did a test build were I removed this entire part:

 SkippedPrograms::const_iterator i = skipped_programs_.find(program_name);
 if (i != skipped_programs_.end()) {
  uint32_t const gametime = game.get_gametime();
  uint32_t const earliest_allowed_start_time = i->second + 10000;
  if (gametime + tdelta < earliest_allowed_start_time)
   tdelta = earliest_allowed_start_time - gametime;
 }

Performance-wise I couldn't see any difference. But wares got produced much faster. As an example: when only shovels are needed, it would take 60 seconds until the smith started producing the shovel because the 10 other tools that usually get produced weren't needed. So it took 130.6 for a new shovel being produced. Without "SkippedPrograms" it now takes only 70.6.

The only "downside" is that the "skipped making..." hover-message isn't shown for 10 seconds. Because it gets replaced by the next "skipped making..."-message. But even with the current 10s waiting time not all "skipped making..."-messages were shown. In case of the metal_workshop, the bread_paddle, hunting_spear & pick's "skipped making..." messages were on screen while the others were omitted. So to be honest I don't think this is a downside at all.

I'd say it would be for the better if this got removed.