Comment 5 for bug 1735967

I just got this - I had 2 windows open: a Barbarian Training Camp and a construction site to enhance an Ax Factory. It happened while I did a right-click on the trainingsite, but that might have been a coincidence.

==27467==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140002041c8 at pc 0x000000e3801f bp 0x7ffe5f0c1a10 sp 0x7ffe5f0c1a00
READ of size 8 at 0x6140002041c8 thread T0
    #0 0xe3801e in std::vector<UI::Table<void*>::EntryRecord*, std::allocator<UI::Table<void*>::EntryRecord*> >::size() const /usr/include/c++/5/bits/stl_vector.h:655
    #1 0x12b992f in UI::Table<void*>::size() const /home/bratzbert/sources/widelands/fh1-tutorials/src/ui_basic/table.h:211
    #2 0x13f4af1 in ProductionSiteWindow::update_worker_table(Widelands::ProductionSite*) /home/bratzbert/sources/widelands/fh1-tutorials/src/wui/productionsitewindow.cc:156
    #3 0x13f2fe3 in operator() /home/bratzbert/sources/widelands/fh1-tutorials/src/wui/productionsitewindow.cc:58
    #4 0x13f5618 in _M_invoke /usr/include/c++/5/functional:1871
    #5 0xff8f3e in std::function<void (Widelands::NoteBuilding const&)>::operator()(Widelands::NoteBuilding const&) const /usr/include/c++/5/functional:2267
    #6 0xff3aae in void Notifications::NotificationsManager::publish<Widelands::NoteBuilding>(Widelands::NoteBuilding const&) /home/bratzbert/sources/widelands/fh1-tutorials/src/notifications/notifications_impl.h:76
    #7 0xfed3ce in void Notifications::publish<Widelands::NoteBuilding>(Widelands::NoteBuilding const&) /home/bratzbert/sources/widelands/fh1-tutorials/src/notifications/notifications.h:51
    #8 0x107732d in Widelands::Building::add_worker(Widelands::Worker&) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/tribes/building.cc:698
    #9 0x10f1bc7 in Widelands::TrainingSite::add_worker(Widelands::Worker&) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/tribes/trainingsite.cc:344
    #10 0x1142c41 in Widelands::Worker::set_location(Widelands::PlayerImmovable*) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/tribes/worker.cc:1046
    #11 0x11443f9 in Widelands::Worker::transfer_update(Widelands::Game&, Widelands::Bob::State&) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/tribes/worker.cc:1343
    #12 0x1021193 in Widelands::Bob::do_act(Widelands::Game&) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/bob.cc:194
    #13 0x1020ee9 in Widelands::Bob::act(Widelands::Game&, unsigned int) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/bob.cc:180
    #14 0x1059024 in Widelands::CmdAct::execute(Widelands::Game&) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/map_objects/map_object.cc:100
    #15 0x1184c41 in Widelands::CmdQueue::run_queue(int, unsigned int&) /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/cmd_queue.cc:123
    #16 0xf96227 in Widelands::Game::think() /home/bratzbert/sources/widelands/fh1-tutorials/src/logic/game.cc:552