Toolbar redesign
Bug #1643563 reported by
GunChleoc
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Since we are using some gaps now to group the toolbar buttons, I think the toolbar needs a background. I am attaching a rough mockup, which also adds system time and gametime.
Forum thread: https:/
Related branches
lp:~widelands-dev/widelands/toolbar-dropdown-menus
- Klaus Halfmann: Approve (comile, regression test)
-
Diff: 4562 lines (+1554/-1198)82 files modifieddata/images/wui/menus/CREDITS.txt (+1/-0)
data/tribes/atlanteans.lua (+21/-0)
regression_test.py (+3/-0)
src/editor/CMakeLists.txt (+0/-4)
src/editor/editorinteractive.cc (+330/-84)
src/editor/editorinteractive.h (+84/-24)
src/editor/ui_menus/main_menu.cc (+0/-110)
src/editor/ui_menus/main_menu.h (+0/-53)
src/editor/ui_menus/main_menu_load_map.cc (+2/-2)
src/editor/ui_menus/main_menu_load_map.h (+1/-1)
src/editor/ui_menus/main_menu_load_or_save_map.cc (+2/-2)
src/editor/ui_menus/main_menu_load_or_save_map.h (+3/-2)
src/editor/ui_menus/main_menu_map_options.cc (+8/-16)
src/editor/ui_menus/main_menu_map_options.h (+5/-4)
src/editor/ui_menus/main_menu_new_map.cc (+2/-2)
src/editor/ui_menus/main_menu_new_map.h (+3/-3)
src/editor/ui_menus/main_menu_random_map.cc (+2/-2)
src/editor/ui_menus/main_menu_random_map.h (+3/-3)
src/editor/ui_menus/main_menu_save_map.cc (+30/-22)
src/editor/ui_menus/main_menu_save_map.h (+9/-1)
src/editor/ui_menus/player_menu.cc (+2/-2)
src/editor/ui_menus/player_menu.h (+3/-2)
src/editor/ui_menus/tool_change_height_options_menu.cc (+1/-1)
src/editor/ui_menus/tool_change_resources_options_menu.cc (+1/-1)
src/editor/ui_menus/tool_menu.cc (+0/-193)
src/editor/ui_menus/tool_menu.h (+0/-37)
src/editor/ui_menus/tool_noise_height_options_menu.cc (+1/-1)
src/editor/ui_menus/tool_options_menu.cc (+6/-6)
src/editor/ui_menus/tool_options_menu.h (+4/-2)
src/editor/ui_menus/tool_place_critter_options_menu.cc (+1/-1)
src/editor/ui_menus/tool_place_immovable_options_menu.cc (+1/-1)
src/editor/ui_menus/tool_resize_options_menu.cc (+5/-4)
src/editor/ui_menus/tool_set_terrain_options_menu.cc (+1/-1)
src/graphic/CMakeLists.txt (+10/-0)
src/graphic/toolbar_imageset.cc (+38/-0)
src/graphic/toolbar_imageset.h (+43/-0)
src/logic/CMakeLists.txt (+1/-0)
src/logic/map.cc (+4/-0)
src/logic/map.h (+0/-1)
src/logic/map_objects/CMakeLists.txt (+1/-0)
src/logic/map_objects/tribes/tribe_descr.cc (+7/-0)
src/logic/map_objects/tribes/tribe_descr.h (+7/-0)
src/logic/note_map_options.h (+32/-0)
src/notifications/note_ids.h (+2/-1)
src/scripting/lua_game.cc (+12/-1)
src/scripting/lua_game.h (+1/-0)
src/scripting/lua_ui.cc (+18/-1)
src/scripting/lua_ui.h (+1/-0)
src/ui_basic/dropdown.cc (+0/-14)
src/ui_fsmenu/internet_lobby.cc (+2/-5)
src/ui_fsmenu/launch_mpg.cc (+1/-1)
src/wui/CMakeLists.txt (+1/-4)
src/wui/buildingwindow.cc (+1/-1)
src/wui/constructionsitewindow.cc (+1/-1)
src/wui/economy_options_window.cc (+3/-13)
src/wui/fieldaction.cc (+1/-42)
src/wui/game_chat_menu.cc (+3/-1)
src/wui/game_chat_menu.h (+2/-0)
src/wui/game_client_disconnected.cc (+1/-1)
src/wui/game_message_menu.cc (+3/-3)
src/wui/game_options_menu.cc (+0/-119)
src/wui/game_options_menu.h (+0/-49)
src/wui/game_statistics_menu.cc (+0/-98)
src/wui/game_statistics_menu.h (+0/-52)
src/wui/game_summary.cc (+1/-1)
src/wui/interactive_base.cc (+152/-54)
src/wui/interactive_base.h (+52/-12)
src/wui/interactive_gamebase.cc (+232/-6)
src/wui/interactive_gamebase.h (+76/-20)
src/wui/interactive_player.cc (+134/-45)
src/wui/interactive_player.h (+24/-2)
src/wui/interactive_spectator.cc (+12/-41)
src/wui/interactive_spectator.h (+0/-1)
src/wui/mapdetails.cc (+2/-0)
src/wui/mapdetails.h (+4/-0)
src/wui/mapview.cc (+19/-6)
src/wui/mapview.h (+7/-0)
src/wui/seafaring_statistics_menu.cc (+1/-1)
src/wui/watchwindow.cc (+2/-2)
test/maps/lua_testsuite.wmf/scripting/ui.lua (+18/-11)
test/maps/plain.wmf/scripting/test_ui.lua (+86/-0)
utils/buildcat.py (+1/-1)
lp:~widelands-dev/widelands/fix-dropdowns
- Klaus Halfmann: Needs Fixing (testplay)
-
Diff: 2577 lines (+782/-513)44 files modifieddata/templates/default/init.lua (+20/-0)
src/editor/CMakeLists.txt (+2/-0)
src/editor/ui_menus/main_menu_new_map.cc (+5/-34)
src/editor/ui_menus/main_menu_new_map.h (+3/-4)
src/editor/ui_menus/main_menu_random_map.cc (+15/-57)
src/editor/ui_menus/main_menu_random_map.h (+2/-2)
src/editor/ui_menus/map_size_box.cc (+76/-0)
src/editor/ui_menus/map_size_box.h (+57/-0)
src/editor/ui_menus/player_menu.cc (+10/-10)
src/editor/ui_menus/tool_resize_options_menu.cc (+21/-58)
src/editor/ui_menus/tool_resize_options_menu.h (+3/-4)
src/graphic/style_manager.cc (+2/-1)
src/graphic/styles/font_style.h (+1/-0)
src/graphic/styles/table_style.h (+6/-2)
src/graphic/text/rt_parse.cc (+4/-2)
src/graphic/text_layout.cc (+7/-0)
src/graphic/text_layout.h (+2/-0)
src/scripting/lua_ui.cc (+135/-32)
src/scripting/lua_ui.h (+38/-1)
src/ui_basic/button.cc (+1/-3)
src/ui_basic/button.h (+0/-3)
src/ui_basic/checkbox.cc (+2/-2)
src/ui_basic/checkbox.h (+2/-2)
src/ui_basic/dropdown.cc (+93/-59)
src/ui_basic/dropdown.h (+42/-22)
src/ui_basic/icongrid.cc (+1/-1)
src/ui_basic/icongrid.h (+1/-1)
src/ui_basic/listselect.cc (+98/-74)
src/ui_basic/listselect.h (+30/-40)
src/ui_basic/panel.cc (+10/-3)
src/ui_basic/panel.h (+3/-2)
src/ui_basic/radiobutton.cc (+1/-1)
src/ui_basic/radiobutton.h (+1/-1)
src/ui_basic/slider.h (+0/-1)
src/ui_basic/unique_window.cc (+7/-1)
src/ui_fsmenu/launch_game.cc (+3/-3)
src/ui_fsmenu/launch_spg.cc (+2/-0)
src/ui_fsmenu/options.cc (+12/-10)
src/wui/economy_options_window.cc (+1/-1)
src/wui/fieldaction.cc (+1/-1)
src/wui/game_client_disconnected.cc (+3/-2)
src/wui/game_message_menu.cc (+17/-25)
src/wui/multiplayersetupgroup.cc (+12/-8)
src/wui/seafaring_statistics_menu.cc (+30/-40)
Changed in widelands: | |
milestone: | build20-rc1 → build21-rc1 |
description: | updated |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
To post a comment you must log in.
Since most people use widescreen monitors nowadays, maybe the toolbar should be vertical?