Work area preview/highlight
Bug #1619402 reported by
Steven De Herdt
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
Minor inconsistency: if an expedition is started or ready at a port with its window open (or rolled up), and its work area was not highlighted, it will become so.
(That's a short bug!)
Redesign discussion: https:/
Related branches
lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition
- Klaus Halfmann: Needs Resubmitting
-
Diff: 845 lines (+134/-103)26 files modifiedsrc/logic/map_objects/tribes/workarea_info.h (+1/-1)
src/ui_fsmenu/options.cc (+0/-6)
src/ui_fsmenu/options.h (+0/-2)
src/wlapplication.cc (+0/-1)
src/wui/actionconfirm.cc (+1/-0)
src/wui/buildingwindow.cc (+28/-14)
src/wui/buildingwindow.h (+4/-2)
src/wui/constructionsitewindow.cc (+4/-4)
src/wui/constructionsitewindow.h (+3/-2)
src/wui/dismantlesitewindow.cc (+3/-3)
src/wui/dismantlesitewindow.h (+1/-1)
src/wui/fieldaction.cc (+4/-4)
src/wui/interactive_base.cc (+10/-7)
src/wui/interactive_base.h (+7/-6)
src/wui/interactive_gamebase.cc (+19/-15)
src/wui/interactive_gamebase.h (+9/-2)
src/wui/interactive_player.cc (+4/-4)
src/wui/interactive_spectator.cc (+4/-4)
src/wui/militarysitewindow.cc (+4/-4)
src/wui/militarysitewindow.h (+3/-2)
src/wui/productionsitewindow.cc (+5/-4)
src/wui/productionsitewindow.h (+3/-2)
src/wui/trainingsitewindow.cc (+6/-5)
src/wui/trainingsitewindow.h (+3/-2)
src/wui/warehousewindow.cc (+5/-4)
src/wui/warehousewindow.h (+3/-2)
| Changed in widelands: | |
| status: | New → Triaged |
| milestone: | none → build20-rc1 |
| importance: | Undecided → Low |
| tags: | added: ui |
| Changed in widelands: | |
| assignee: | nobody → GunChleoc (gunchleoc) |
| status: | Triaged → In Progress |
| description: | updated |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| summary: |
- Port's work area lights up on expedition event + Work area preview/highlight |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | GunChleoc (gunchleoc) → nobody |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
From the forum discussion, we should have the following design for work area previews:
1. When placing a building: always on
2. When having a building window open: off by default, but button to switch it on
3. Get rid of the general option to switch previews off