widelands

Idle ships shows "Shipping" in statistic mode = "s"-key

Bug #1618617 reported by kaputtnik
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Unassigned
widelands build20-rc1

Bug Description

If you use the "s" key to show the statistics on each building, for normal ships the string shows always "Shipping", even the ship does nothing and sails are stroked.

It would be nice have an additional string as for expeditions:

Idle: "Waiting"

Related branches

lp:~widelands-dev/widelands/bug-1358880-ship-statistics
Notabilis: Approve
GunChleoc: Needs Resubmitting
Diff: 2040 lines (+1087/-215)
23 files modified
data/tribes/scripting/help/controls.lua (+39/-12)
src/ai/defaultai.cc (+10/-6)
src/ai/defaultai.h (+1/-1)
src/game_io/game_player_info_packet.cc (+2/-2)
src/logic/map_objects/tribes/ship.cc (+39/-32)
src/logic/map_objects/tribes/ship.h (+9/-20)
src/logic/player.cc (+27/-3)
src/logic/player.h (+8/-1)
src/notifications/note_ids.h (+1/-2)
src/scripting/lua_game.cc (+7/-21)
src/ui_basic/table.cc (+12/-0)
src/ui_basic/table.h (+25/-3)
src/wui/CMakeLists.txt (+2/-0)
src/wui/game_statistics_menu.cc (+12/-1)
src/wui/interactive_gamebase.cc (+21/-18)
src/wui/interactive_gamebase.h (+2/-0)
src/wui/interactive_player.cc (+11/-0)
src/wui/seafaring_statistics_menu.cc (+580/-0)
src/wui/seafaring_statistics_menu.h (+159/-0)
src/wui/shipwindow.cc (+42/-33)
src/wui/shipwindow.h (+2/-1)
src/wui/watchwindow.cc (+20/-57)
src/wui/watchwindow.h (+56/-2)
Revision history for this message
TiborB (tiborb95) wrote :

Without looking into code, I guess shipping here means "ware transport mode" and there are no "submodes"....

Revision history for this message
kaputtnik (franku) wrote :

Ok, that makes sense, but in "expedition mode" there is also a state called "Waiting".

At Least "Shipping" is translated into german as "Liefert Waren" (i guess translating back to english: "deliver wares"), which is quite annoying when the ships just do nothing else then waiting...

Revision history for this message
GunChleoc (gunchleoc) wrote :

There is a longish discussion on Transifex on how to label this, so it is a bit tricky.

https://www.transifex.com/widelands/widelands/translate/#de/widelands/80385612?q=shipping

Technically, the ship is in "Transport" mode, there's just nothing for it to transport at the moment, or it might be loading wares... it would mean extra code to change this that is not trivial, so I don't think it's worth the potential bugs a change can introduce.

The best solution IMO is to try to find a better translation.

Revision history for this message
kaputtnik (franku) wrote :

This isn't meant to be solved in near future :-)

I am fine with finding a better translation, but in the end my suggestion would also make the translation easier.

I mark this as a whishlist. Feel free to change it.

Changed in widelands:
importance: Undecided → Wishlist
GunChleoc (gunchleoc)
Changed in widelands:
status: New → In Progress
assignee: nobody → GunChleoc (gunchleoc)
milestone: none → build20-rc1
Revision history for this message
GunChleoc (gunchleoc) wrote :

This was easier to implement than I thought, so I went ahead, because we can use it in the ship statistics.

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.