Waves are rolling in different speed /rolling angle is different

[kaputtnik]

Because there are different count of water images in each terrain the animation of waves do have different speed.

The waves of "winterland" roll in a different angle than the other ones.

See topic https://wl.widelands.org/forum/topic/1624 for further explanation.

[SirVer (sirver)]

I think a simple rotate will fix that. world/terrains/init.lua contains a "fps" (frames per second) parameter for each animated texture - you can adjust the wave rolling speed with that.

The original idea was that ice sea is more stormy than desert see - but if you believe there is a benefit in making the graphics mesh better, I do not see an issue at all.

[kaputtnik (franku)]

Thanks for comment :-)

Using different water could bring more possibilitys to build the coastline. i.e. makes an atoll look better. Precondition is that all water types act the same way in animation. A wave should optical roll over all types of water, also on adjacent watertypes. So i think it is importand to have the same animation over all watertypes, which includes the same number of pictures.

I try your suggestion to play around with the fps value.

Thanks

[SirVer (sirver)]

there is also no issue of just adding more water types - just add the graphics and an entry in terrains/init.lua. If you want more similar waters, just use the same settings and change graphics. As long as you do not rename any of the "name" entries, all maps will still work. Adding new types is uncritical.

[kaputtnik (franku)]

The waves from winter has to be only flipped vertically. I added a zip-file which contains the corrected images.

The fps values could be left as they are, imho. Water looks a bit "nervous" or "turbulent", but its not disturbing in my mind.

Thanks :-)

[Chuck Wilder (chuckw20)]

kaputtnik, thank you for the graphics. It will be a pleasure to check them over. I'm excited about the expanded use and potential of the terrains that is now available.

[kaputtnik (franku)]

Because Chuck is busy with other things, i proposed a branch to the issue of rolling waves in different angle. I want this to be fixed.... :-D

I looked into the media branch but i didn't get an idea how this is organized. The files related to water terrains are outdated... I think widelands-media is a repo where the "making of" files are stored (f.e. gimp-xcf or blender files) and the resulting images are in the widelands repo. So i propose only a branch for widelands, but not for widelands-media because i flipped only the existing images.

[kaputtnik (franku)]

Hmm... must i remove each file and add the new one?

[GunChleoc (gunchleoc)]

You can just replace files.

[kaputtnik (franku)]

Thanks :-)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.