Comment 5 for bug 1388829

Revision history for this message
SirVer (sirver) wrote :

I agree that no abberviated names are preferable. however, brn (bottom right neighbor), bln, tln, trn, rn, ln are idioms in Widelands - they are used in many places. I opted for local style instead of non-abbreviation.

Also, this was just a copy & pasto. It is kinda obvious that you would check the variable you just calculated and not one that you've used a few lines further up already. Especially since the pattern is repeated multiple times.

No, I think this mistake was hard to avoid. And I am happy if it stays the only bug in the new rendering code - that was a very difficult rewrite.