Comment 4 for bug 1322869

Revision history for this message
SirVer (sirver) wrote :

> readout certain data, as Widelands does check_used() checks on those data, which is just wasted CPU and time... :(

not sure what you want to say with that? checking that values of configuration files are used is certainly a good thing to do - it will prevent future bugs. If you do not care for the dummy implementation, add a 'mark all keys as read' call to Section and LuaTable.

> Concerning "the proper fix" - it was that way in Build 17, so unfortunally this is more or less a regression :-/.

No, we never had logic and UI separated. Try building logic/* economy/* into one library. If this works without needed headers or libraries from ui_basic or wui/ or graphics/ we would be there, but that never works and will not work for a long time.

concerning the regression: untested code regresses easily, especially one that relies on if/else checks in many places of the code. Add a regression test to the testsuite and it will not regress again.