Training grounds description vs Warrior's axe description

[GunChleoc]

From IRC:

<teh_f4ll3n>GunChleoc2: I see. is there a place I could list things that don't make sense to me? like Training grounds description vs Warrior's axe description
<teh_f4ll3n>ax*
<teh_f4ll3n>for instance: descr on the ax says train attack fron 4 to 5 in traning grounds, but the TG descr says only up to 4
<hjd>teh_f4ll3n: That sounds like a bug in one of the descriptions

[Lex (teh-f4ll3n)]

in the same 'barbarians' file:
the description for shovel still says 'ferner' instead of 'gardener' and there's a 'ferner' string in there too

[GunChleoc (gunchleoc)]

We should have a look at our level semantics in general. From the conf file:

upgrade_soldier_attack_0=_Upgrade soldier attack 0
upgrade_soldier_attack_1=_Upgrade soldier attack 1
upgrade_soldier_attack_2=_Upgrade soldier attack 2
upgrade_soldier_attack_3=_Upgrade soldier attack 3
upgrade_soldier_attack_4=_Upgrade soldier attack 4

upgrade_soldier_attack_0 would mean that soldiers start with level 0 and then upgrade from level 0. upgrade_soldier_attack_4 means that they upgrade from level 4 to level 5.

How intuitive is it to have units start with level 0? I think it would feel more natural to have them start with level 1. This would entail breaking a few strings again, but I'd like to revise these anyway, because they're a bit opaque to the casual user.

On another note, for which build was it planned to remove upgrade_attack_0=_Upgrade soldier attack 0 (only for compatibility with old savegames (build13)) etc?

[GunChleoc (gunchleoc)]

The ferner has been taken care of.

[SirVer (sirver)]

Level 0 makes more sense though as the soldiers icon is all white and gets points for each level. So I vote for keeping it.

We tried to keep backwards compatible for 3 builds, so this should have been removed with build 17. But we can remove it now for sure.

[GunChleoc (gunchleoc)]

OK, thanks. Will do :)

[Hans Joachim Desserud (hjd)]

If you do end up removing the build13-compatibility lines, please update the status of bug 1289745. :)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.