Training sites have programs for compatibility with old savegames (build13)

Bug #1289745 reported by Hans Joachim Desserud
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

As an example, here's the programs entry from Atlanteans Labyrinth:

[programs]
sleep=_Sleep
upgrade_soldier_defense_0=_Upgrade soldier defense 0
upgrade_defense_0=_Upgrade soldier defense 0 (only for compatibility with old savegames (build13))
upgrade_soldier_defense_1=_Upgrade soldier defense 1
upgrade_defense_1=_Upgrade soldier defense 1 (only for compatibility with old savegames (build13))
upgrade_soldier_hp_0=_Upgrade soldier health 0
upgrade_hp_0=_Upgrade soldier health 0 (only for compatibility with old savegames (build13))
upgrade_soldier_evade_0=_Upgrade soldier evade 0
upgrade_evade_0=_Upgrade soldier evade 0 (only for compatibility with old savegames (build13))
upgrade_soldier_evade_1=_Upgrade soldier evade 1
upgrade_evade_1=_Upgrade soldier evade 1 (only for compatibility with old savegames (build13))

As we can see, half of the programs are merely for compatibility reasons for older save games. Since build 13 is quite some time ago, I don't know how this has worked in recent releases. Regardless, since the change to eris breaks all compatibility anyways these entries can be removed. Is it sufficient to clean up the conf-files, or are there parts of the source code looking for these too?

Tags: savegame
Revision history for this message
SirVer (sirver) wrote :

Yes, we do not give any compatibility guarantees till b19 is out of the door. Everything that mentions compatibility can be killed on sight.

I do not know if some code is looking for these entries, but starting with removing those and then killing all code that complains is probably a workable solution.

Changed in widelands:
status: New → Confirmed
Revision history for this message
GunChleoc (gunchleoc) wrote :

As far as I could grep, it's the conf files only.

I have fixed this with

https://bugs.launchpad.net/widelands/+bug/1290073

Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
SirVer (sirver)
Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.