Comment 4 for bug 1228811

Revision history for this message
SirVer (sirver) wrote :

> No, It does not crash anymore. Thanks for the quick fix. I guess that we would have found this one during the tournament.

not sure about that. I think most people play in OpenGL mode these days anyway.

> There might still be something ugly in saving (Map_Port_Spaces_Data_Packet::Write, see attachment). No crashes, though.

There was some code there that copied a set and then conditionally deleted from it in a BOOST_FOREACH. I am not sure if this is valid - I did not find any documentation about it. But it feels funky to delete an element while iterating over a container. Instead I changed the code to not copy the set and delete, but instead starting with an empty set and inserting the values we really want to have.

This fix is slightly more invasive that I would have liked it to be, but seems still save enough.