Port window not updated ("Cancel the expedition" starts a new one)

[wl-zocker]

After having started an expedition and the wares are being delivered, cancelling the expedition will cancel it (as expected).
But if you keep the port window open and wait until the ship has arrived (the wares from the port will disappear), the button still reads "Cancel the expedition". However, when you click on it, another expedition will start. (Tested in r6581. Take care of bug 1191554 when trying to reproduce this one.)
Would it be able to update the window of the port when the expedition has started?

[Nasenbaer (nasenbaer)]

agreed in all points :)

[Nasenbaer (nasenbaer)]

Fixed in bzr. 6585

[SirVer (sirver)]

Released in build-18 rc1.

[wl-zocker (wl-zocker)]

This happens again in r7199. The button still says "Cancel", but a new expedition is started.
Even when there is no expedition, there is an empty expedition tab.
Could maybe be fixed at the same time: When the status of an expedition changes (started/cancelled/ship gets loaded), the first tab of the port (showing the wares) becomes active. It would be nice if the currently active tab stayed active.

[SirVer (sirver)]

This can be implemented using the notifications framework and should work non-obstructively.

[Hans Joachim Desserud (hjd)]

Updated milestone so we don't forget about this for build19.

[Hans Joachim Desserud (hjd)]

Confirmed in r7438.

Looks like when you cancel an expedition in the port window, the button never goes back to start expedition, so it is effectively possible to toggle it on and off by clicking "cancel" multiple times.

[GunChleoc (gunchleoc)]

Another description of this bug: https://bugs.launchpad.net/widelands/+bug/1522582/comments/1

[Klaus Halfmann (klaus-halfmann)]

Looks like this was fixed in the Branch created by Gun.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.