Comment 14 for bug 1121982

On Mon, Mar 18, 2013 at 8:43 PM, Kiscsirke <email address hidden> wrote:

> There were some further erroneous conf files, I corrected them in rev
> #6536.
>

Thanks. I thought I caught them all with a text search I did. I know this
isn't exactly "Testing in production", but I still hate to produce sloppy
work.

> I think the difference isn't Windows/Linux, but that you built a Release
> version, and that does less checks? If so, try compiling a debug build
> and testing with that. (The compile.sh script asks if you want a debug
> or release build.)
>

I'll do that from now on. Thx

>
>
I don't know what your current process for editing these is, but I guess
> it could be more automatized, from seeing the number of potential
> mistakes?
>

In all of these

incidents, it was/is entirely manual owing to the limitations of SirVer's
script currently. (You KNOW that I didn't write it. Right? Pythonxy?
Me?!! Yeah, sure..) :) I wish I DID know some Python, though, to handle
just this type of situation. I don't know of any keyboard macro utility
that could glean image dimensions and enter them in an edited text file.
Heck, I don't know any keyboard macro utilities PERIOD outside of Lotus
123. You probably don't remember that product. ;)

> Also 2 other comments on the branch:
> - Is there any reason for 'dimensions' and 'base_offset' to be a
> different format from 'hotspot'? (They use commas instead of spaces.) Being
> the same would be more logical to me. I would think it could also use the
> same code?
>
>

Again, the make_spritemap.py script is SirVer's baby. The hotspot has
always been space delimited. I couldn't even guess why he uses a comma for
the dimensions and offset.

>
> - I think we should set some conventions on the image file naming. Right
> now there are folders where it's "idle_xx" and so on, and there are folders
> where the image files are named after the object too. With the conversion
> in this branch, some were converted from the former to the latter. I would
> actually prefer the former, it makes it easy to search for files "idle*" in
> all those folders, and the folder name already describes the object anyway.
> But again, setting some convention and sticking with it would be better in
> either case.
>

I agree there should be some standard. SirVer's current approach is to map
all of the animation images, (i.e. build, idle, working, etc.) into one
common png file (plus a _pc file if there is playercolor). Therefore, he
elected to use the folder name as the file name. For now, I don't see him
changing this approach.

He's frightfully busy right now. So, I have been trying to document the
errors the script is currently encountering for him and manually converting
the single image pngs for consistency until the mapping script is modified
to handle them, too, if ever.

It's not just single-image pngs that are giving us errors. I've yet to
successfully run it for a traveling bob. Even some buildings are
generating errors I'm guessing because the input images are of differing
dimensions. Hence the still lengthy list of barbarian buildings and
workers that are yet to be converted.

There is a lot to do (well over 700 items), including the terrain,
unmovables and bobs for each world. Even exercising my most extreme care,
I'm going to continue to make mistakes if I rely on my hands to do the
editing.

I'd appreciate any suggestions you might offer.

Thanks again.
Chuck