Comment 3 for bug 1615364

Revision history for this message
kaputtnik (franku) wrote :

> I think using the Name Displayed on the website makes sense
Agreed

> why should we use the uploaded name which could be completely non related like temp1.wmf.
I believe such a name will never be used:

- A file name is much important for a user. Having maps called temp[1...x].wmf one will never find the map he is searching for.
- When saving a map in editor the suggested file name is build of of the name in options. If it is "No Name" (default) then the suggested file name is "No Name".
- When saving a map without modifying the name in options, the map get saved containing the file name as map name in options. If the file name is "my first map" then the map name in options is turned into "my first map"

> what is valid on one os is not necessarily on another. So I suggest we replace non ascii and dangerous characters in the map name when creating the file name.

As i know the save dialogue of editor does this exactly right now. It is afaik impossible to give a map a file name containing special characters (couldn't find the merge or the code yet). Why should we implement the same thing twice?

As i understood you want to replace some characters of a maps name to become a valid file name. So there will be three names in the end:
"map 64x64.wmf" (original file name) -> "map 64/64" (name of map shown on the website) -> "map 64_64.wmf" (delivered file name)

What if a maps name is something like "Jundlina asks: "Is there a place to live?"" This would become to: "Jundlina asks_ _Is there a place to live__.wmf". The uploaded file name given by the author is maybe just: "Jundlina asks.wmf"...

Currently the fields in map options could also be empty (bug 1544474). Uploading a map with empty "name" field is possible, but leads to a crash on the website everytime the maps page gets opened (ok, another bug)

I think the file name of a map is the only valid thing we have. I am in favor of making things not to complicated: Show the maps name on the website like it is now, but add the original filename to the details table (File name: map 64x64.wmf) and deliver the map with the original file name.