Comment 2 for bug 1615364

Revision history for this message
SirVer (sirver) wrote : Re: [Bug 1615364] Re: wlmaps: Downloading a map depends on map name, not map filename

I think using the Name Displayed on the website makes sense - why should we use the uploaded name which could be completely non related like temp1.wmf.

The specials characters are an issue though - and they are not addressed by using the uploaders file name: what is valid on one os is not necessarily on another. So I suggest we replace non ascii and dangerous characters in the map name when creating the file name.

> Am 21.08.2016 um 18:37 schrieb kaputtnik <email address hidden>:
>
> Of course it could also be confusing when a map is shown up with name
> 'First test' and by download it is saved as 'atlantean mission.wmf'.
> Maybe we have to display also the filename on the homepage to clarify.
>
> --
> You received this bug notification because you are subscribed to
> Widelands Website.
> https://bugs.launchpad.net/bugs/1615364
>
> Title:
> wlmaps: Downloading a map depends on map name, not map filename
>
> Status in Widelands Website:
> New
>
> Bug description:
> Two strange things:
>
> 1. One creates a map, gives the map a name in editor map options but
> saves it with a different name. F.e.:
>
> - Map name (editor options): 'First test'
> - Filename: 'Atlanteans mission'
>
> After uploading the map on the website the map name "First test" is
> shown up. When downloading you will get a map called 'First test.wmf',
> not the real filename 'Atlanteans mission.wmf'. Not a big problem but
> confusing.
>
> 2. Because the name of a map (set in editor map options) could contain
> special characters (like a slash) this could lead into misbehavior.
> F.e.:
>
> - Map name (editor map options): 'map 64/64'
> - Filename: 'map 64x64' (saving with a slash isn't possible in editor)
>
> When uploading on the Website the Mapname is shown as "map 64/64"
> which seems to be correct, but trying to download result in a
> downloaded file called '64.wmf'.
>
> I think we should deliver the map file with his real filename, not the
> name given in editor map options.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/widelands-website/+bug/1615364/+subscriptions