Comment 14 for bug 1615364

Revision history for this message
kaputtnik (franku) wrote :

> We would have 2 such fields, one for the map name, and 1 for the file name,

So if all options are filled out we will have at least 4 names of one map:
Nr. 1 and 2 given when saving a map: Name given in map options and a (maybe different) file name
Nr. 3 and 4 given in the upload form for file name and map name

> ideally prefilled from the map file that the user is trying to upload.

This data could only be used if a map has been uploaded yet. How will you otherwise get the map name (given in map options)? The prefilled file name could only be displayed with some javascript coding (executed in the users browser)

Additionally all things are much complicated:

Beside there are several maps saved on the server which are not available for download, if a maps file name already exist on the server, django changes the name to a name containing random chars. F.e. If a file name 'foo.wmf' already exists, the new uploaded file will become a name 'foo_j8kl65.wmf'

Providing the file name for download may result in unexpected results then. As long as i think/investigate this i feel the current solution is better (deliver the file with the name from maps options). We have just to create a safe file name ... hmmm