Comment 3 for bug 1848020

Hi Guido,

Guido Maria Serra wrote:
> > I would have already uploaded it to Debian Experimental, but I
> > currentlyfight with test suite failures on some machines.
> what do u mean with "on some machines?" ...specific architectures?

Yes, but I can't say if it's the architecture or still unknown missing
test suite dependencies as the variety of hardware I have doesn't have
much significance:

I was IIRC able to build it on my EeePC 900A (i386), but I wasn't able
to build on either my workstation (amd64, has no wifi at all), my
Thinkpad X250 (amd64) nor in a clean Debian Sid amd64 chroot with all
(known) build dependencies installed.

The failing test is the following:

test_needs_external_calls_not_implemented (tests.testwnettools.TestWnettools) ... ok
test_parse_new_cfg80211_interface_stdout (tests.testwnettools.TestWnettools) ... FAIL
test_wext_is_valid_wpasupplicant_driver (tests.testwnettools.TestWnettools) ... ok

======================================================================
FAIL: test_parse_new_cfg80211_interface_stdout (tests.testwnettools.TestWnettools)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/mock.py", line 1255, in patched
      return func(*args, **keywargs)
        File "/build/wicd-1.7.4+tb2+2019.09.18git2e0ba579/.pybuild/cpython3_3.7/build/tests/testwnettools.py", line 21, in test_parse_new_cfg80211_interface_stdout
     self.assertGreater(len(cells), 0)
     AssertionError: 0 not greater than 0

----------------------------------------------------------------------
Ran 61 tests in 0.907s

FAILED (failures=1)
E: pybuild pybuild:341: test: plugin distutils failed with: exit code=1: cd /build/wicd-1.7.4+tb2+2019.09.18git2e0ba579/.pybuild/cpython3_3.7/build; python3.7 -m unittest discover -v
dh_auto_test: pybuild --test -i python{version} -p 3.7 returned exit code 13
make[1]: *** [debian/rules:31: override_dh_auto_test] Error 255

I also tried the following patch to add further build-dependencies I
suspected to be used in the test, but it didn't change much if
anything:

diff --git a/debian/changelog b/debian/changelog
index 139891c..767a792 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -25,6 +25,7 @@ wicd (1.7.4+tb2+2019.09.18git2e0ba579-1) UNRELEASED; urgency=low
       dh_auto_test, i.e. the test suite.
     + Add some more files (mostly under "other") to debian/clean.
     + Add iw as dependency. iwconfig seems not yet fully replaced though.
+ + Add build-dependencies for new test-suite, mostly wireless stuff.
     + Vcs-Git: Set branch to python3 until merged into master.
   * Bump debhelper compatibility level to 12.
     + Build-depend on "debhelper-compat (= 12)" to replace debian/compat.
diff --git a/debian/control b/debian/control
index bc2a85f..3a7434c 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,10 @@ Uploaders: Axel Beckert <email address hidden>,
            Giap Tran <email address hidden>
 Build-Depends: debhelper-compat (= 12),
                dh-python,
- python3
+ iw <!nocheck>,
+ python3,
+ wireless-tools <!nocheck>,
+ wpasupplicant <!nocheck>
 Build-Depends-Indep: gettext,
                      po-debconf,
                      python3-babel,

Maybe you have an idea.

  Regards, Axel
--
 ,''`. | Axel Beckert <email address hidden>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
  `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE