> Two things need to happen:
>
> 1) Make _unicode=False unecessary. How?
> 2) Have a try, if you can't decode the unicode, then it's binary and leave it alone in an except.
> 3) If _unicode=False is given then assume it's binary and shortcircuit so you don't need to above.
I've a fix to avoid unicode conversion of uploaded files. Need to
polish it some more before checking in.
> Now, as to why you decided this was don't fix when the original poster
> said clearly that it pegs their CPU at 100% is beyond me, but now let's
> frame this as a serious DOS attack against your framework and you work
> from that premise instead.
100% CPU issue is because of an error in web.debugerror. It is already
fixed (Sorry, I forgot to inform about that).
> Two things need to happen:
>
> 1) Make _unicode=False unecessary. How?
> 2) Have a try, if you can't decode the unicode, then it's binary and leave it alone in an except.
> 3) If _unicode=False is given then assume it's binary and shortcircuit so you don't need to above.
I've a fix to avoid unicode conversion of uploaded files. Need to
polish it some more before checking in.
> Now, as to why you decided this was don't fix when the original poster
> said clearly that it pegs their CPU at 100% is beyond me, but now let's
> frame this as a serious DOS attack against your framework and you work
> from that premise instead.
100% CPU issue is because of an error in web.debugerror. It is already
fixed (Sorry, I forgot to inform about that).
http:// github. com/webpy/ webpy/commit/ dea8e7705467524 5158507171abafa 533cf5d1bc
And it is not a DOS attack issue because it is not in the core
framework, but in the debugerror used only during development (which
is anyway fixed).
Anand